Skip to content

LT-22161: Show approval source in parsing development mode#409

Merged
jtmaxwell3 merged 3 commits into
release/9.3from
LT-22161
Jul 24, 2025
Merged

LT-22161: Show approval source in parsing development mode#409
jtmaxwell3 merged 3 commits into
release/9.3from
LT-22161

Conversation

@jtmaxwell3

@jtmaxwell3 jtmaxwell3 commented Jul 23, 2025 •
edited by jasonleenaylor
Loading

Copy link
Copy Markdown
Collaborator

This implements https://jira.sil.org/browse/LT-22161. Beth agreed to this in the last comment.

This change is Reviewable

@jasonleenaylor

jasonleenaylor commented Jul 23, 2025

Copy link
Copy Markdown
Contributor

Src/LexText/Interlinear/InterlinVc.cs line 884 at r1 (raw file):

			vwenv.set_IntProperty((int)FwTextPropType.ktptBorderLeading, (int)FwTextPropVar.ktpvMilliPoint, width);
			vwenv.set_IntProperty((int)FwTextPropType.ktptBorderTrailing, (int)FwTextPropVar.ktpvMilliPoint, width);
			vwenv.set_IntProperty((int)FwTextPropType.ktptBorderColor, (int)FwTextPropVar.ktpvDefault, color);

So this will always set a border color, but it won't be visible unless we are in parsingdevmode. Does it disappear if we switch out of dev mode? (I'm not sure if the vwenv is reused or recreated)

@jtmaxwell3

jtmaxwell3 commented Jul 23, 2025

Copy link
Copy Markdown
Collaborator Author

It disappears if you switch out of dev mode because InterlinVc gets refreshed whenever the mode changes. This is in the acceptance test.

jasonleenaylor
jasonleenaylor approved these changes Jul 24, 2025
View reviewed changes

@jasonleenaylor jasonleenaylor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, all discussions resolved

@jtmaxwell3 jtmaxwell3 enabled auto-merge (squash) July 24, 2025 17:12
@jtmaxwell3 jtmaxwell3 merged commit 4a08a38 into release/9.3 Jul 24, 2025
4 of 5 checks passed
@jtmaxwell3 jtmaxwell3 deleted the LT-22161 branch July 24, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasonleenaylor jasonleenaylor jasonleenaylor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jtmaxwell3 @jasonleenaylor